Skip to content

ci: set parallel_tests multiplier for all integration suites#2759

Merged
aramprice merged 1 commit into
mainfrom
limit-parallel_tests-concurrency
Jul 2, 2026
Merged

ci: set parallel_tests multiplier for all integration suites#2759
aramprice merged 1 commit into
mainfrom
limit-parallel_tests-concurrency

Conversation

@aramprice

Copy link
Copy Markdown
Member

changing this in hopes of reducing contention on CI workers

Copilot AI review requested due to automatic review settings June 29, 2026 23:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

In ci/pipeline.yml, the PARALLEL_TEST_MULTIPLY_PROCESSES parameter for the integration-postgres job is changed from "0.5" to "0.6" and introduced as a YAML anchor. The integration-postgres-hotswap and integration-mysql jobs are updated to reference this anchor via aliases instead of inline values.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too sparse and omits all required template sections, including tests, release notes, and breaking change info. Fill in each template section: change summary, context, tests run, release note text, breaking-change impact, and team/pair tags.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is clear and related to the CI concurrency tweak, though it slightly overstates the scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch limit-parallel_tests-concurrency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice aramprice requested review from a team, Ivaylogi98 and benjaminguttmann-avtq and removed request for a team June 29, 2026 23:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/tasks/spec.rake`:
- Around line 96-98: Clamp the worker count used by num_procs_flag so it never
returns fewer than 1 worker. Update the num_procs_flag helper to compute the
non-macOS parallelism value safely and ensure the -n argument cannot expand to 0
on low-CPU runners; keep the existing RubyPlatform/darwin branching but force a
minimum of 1 for the nproc-based count.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4a9caa16-3b03-41b6-830a-b48959c9697c

📥 Commits

Reviewing files that changed from the base of the PR and between e2f4965 and 4654ea1.

📒 Files selected for processing (1)
  • src/tasks/spec.rake

Comment thread src/tasks/spec.rake Outdated
@aramprice aramprice force-pushed the limit-parallel_tests-concurrency branch from 4654ea1 to ad9bcd1 Compare June 30, 2026 00:00

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/tasks/spec.rake`:
- Line 17: The SPEC task command in spec.rake is always appending the
parallel_rspec `-n` worker flag, which overrides any CI-provided parallel-tests
multiplier. Update the task-building logic around the parallel_rspec invocation
so `num_procs_flag` is only added when no override is already configured, or
derive the worker count from the existing multiplier instead. Use the spec task
setup and the `parallel_rspec` command string to locate the fix.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5a873e6c-905c-4ebf-8565-3d8069849515

📥 Commits

Reviewing files that changed from the base of the PR and between 4654ea1 and ad9bcd1.

📒 Files selected for processing (1)
  • src/tasks/spec.rake

Comment thread src/tasks/spec.rake Outdated
@aramprice aramprice force-pushed the limit-parallel_tests-concurrency branch from ad9bcd1 to 618c902 Compare June 30, 2026 00:23
@aramprice aramprice changed the title ci: limit parallel_tests gem concurrency to 80% cpu count ci: set parallel_tests multiplier for all integration suites Jun 30, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipeline.yml`:
- Line 315: The shared PARALLEL_TEST_MULTIPLY_PROCESSES anchor is set too low
for the intended concurrency cap. Update the anchored value in the pipeline
configuration from 0.6 to 0.8 so the integration jobs use 80% of CPU count, and
keep the change applied at the PARALLEL_TEST_MULTIPLY_PROCESSES anchor that is
referenced by the integration job definitions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 842d672e-d5ae-4669-a5d2-68034350020b

📥 Commits

Reviewing files that changed from the base of the PR and between ad9bcd1 and 618c902.

📒 Files selected for processing (1)
  • ci/pipeline.yml

Comment thread ci/pipeline.yml
@aramprice aramprice merged commit d16a0a0 into main Jul 2, 2026
24 checks passed
@aramprice aramprice deleted the limit-parallel_tests-concurrency branch July 2, 2026 14:53
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants