Remove deprecated XSS protection setter from HttpHeaderSecurityFilter#3871
Open
gdgenchev wants to merge 1 commit intocloudfoundry:developfrom
Open
Remove deprecated XSS protection setter from HttpHeaderSecurityFilter#3871gdgenchev wants to merge 1 commit intocloudfoundry:developfrom
gdgenchev wants to merge 1 commit intocloudfoundry:developfrom
Conversation
This comes from tomcat-embed-core and it was deprecated. Spring 7 pulls a newer version where this setter does not exist. It seems we already have CSP header setting and this `setXssProtectionEnabled` was set to false anyway, so it seems a safe change.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from tomcat-embed-core and it was deprecated. Spring 7 pulls a newer version where this setter does not exist. It seems we already have CSP header setting and this
setXssProtectionEnabledwas set to false anyway, so it seems a safe change.