Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
if: ${{ github.event_name == 'workflow_dispatch' || github.event_name == 'push' }}
run: python3 e2e/src/main/scripts/run_e2e_test.py --framework yes
- name: Upload report
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: Cucumber report
path: ./plugin/target/cucumber-reports
- name: Upload debug files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: Debug files
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ the License.-->
<modelVersion>4.0.0</modelVersion>
<groupId>io.cdap.tests.e2e</groupId>
<artifactId>cdap-e2e-framework</artifactId>
<version>0.3.2</version>
<version>0.3.3-SNAPSHOT</version>

<name>CDAP e2e Framework</name>
<description>Framework for CDAP e2e Tests</description>
Expand Down Expand Up @@ -340,7 +340,7 @@ the License.-->
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-chrome-driver</artifactId>
<version>4.11.0</version>
<version>4.13.0</version>
</dependency>

<dependency>
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/io/cdap/e2e/utils/ConstantsUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ public class ConstantsUtil {
/**
* DEFAULT_TIMEOUT_SECONDS: To be used in external wait helpers defined in {@link WaitHelper}
*/
public static final int DEFAULT_TIMEOUT_SECONDS = 180;
public static final int DEFAULT_TIMEOUT_SECONDS = 300;
/**
* PAGE_LOAD_TIMEOUT_SECONDS: To be used as Selenium driver's default page load timeout
*/
public static final int PAGE_LOAD_TIMEOUT_SECONDS = 50;
public static final int PAGE_LOAD_TIMEOUT_SECONDS = 300;
/**
* SMALL_TIMEOUT_SECONDS: To be used as a small static wait (only if needed)
*/
public static final int SMALL_TIMEOUT_SECONDS = 5;
public static final int SMALL_TIMEOUT_SECONDS = 20;
/**
* MEDIUM_TIMEOUT_SECONDS: To be used as a medium static wait (only if needed)
*/
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/io/cdap/e2e/utils/SeleniumDriver.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class SeleniumDriver {
ChromeOptions chromeOptions = new ChromeOptions();
chromeOptions.addArguments("--no-sandbox");
chromeOptions.addArguments("--disable-setuid-sandbox");
chromeOptions.addArguments("--headless");
chromeOptions.addArguments("--headless=new");
chromeOptions.addArguments("--window-size=" + SeleniumHelper.readParameters("windowSize"));
chromeOptions.addArguments("--disable-gpu");
chromeOptions.addArguments("--disable-dev-shm-usage");
Expand All @@ -62,7 +62,6 @@ public class SeleniumDriver {
chromePrefs.put("download.default_directory", downloadDir);
chromeOptions.setExperimentalOption("prefs", chromePrefs);
chromeDriver = new ChromeDriver(service, chromeOptions);
chromeDriver.manage().window().maximize();
HttpCommandExecutor executor = (HttpCommandExecutor) chromeDriver.getCommandExecutor();
url = executor.getAddressOfRemoteServer();
waitDriver = new WebDriverWait(chromeDriver, ConstantsUtil.DEFAULT_TIMEOUT_SECONDS);
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/connectionParameters.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Selenium browser window size
windowSize=1920x1040
windowSize=1920,1040
# CDAP application url
cdfurl=http://localhost:11011/pipelines/ns/default/studio
# CDAP Wrangler connections page url
Expand Down
Loading