tests-trigger: add support for wildcard matches - #8129
Closed
allisonkarlitskaya wants to merge 2 commits into
Closed
allisonkarlitskaya wants to merge 2 commits into
allisonkarlitskaya wants to merge 2 commits into
Conversation
None of our repositories use this name anymore and I don't expect we'll ever see any others that do. Keep the infrastructure for per-project main branches in place in case some day we add another repo that uses a name other than 'main'.
This can be helpful if you want to trigger something like '*/networking@*', for example.
Member
Author
|
So I did this from the standpoint of running it from the bots repository itself, similar to |
tomasmatus
reviewed
Aug 19, 2025
| if branch.startswith('_'): | ||
| continue | ||
| for context in contexts: | ||
| c = context + '@' + repo |
Member
There was a problem hiding this comment.
like you say this probably isn't right. I think this should work on the target repository so when I do
./tests-trigger --repo cockpit-project/cockpit 22330 '*/networking'
I'd like to trigger all images that run cockpit tests and their /networking scenario
Member
|
I'd say it's fine to only support wildcard match for image variants and maybe contexts for specific image? So basically |
Member
Author
I kinda feel like doing it at the string level is actually easier... it might be "too powerful" in some sense, but it's also just kinda the easiest way to do it... But probably we do need to do something about the launch context: if we're in a repo other than bots we probably want to only refer to the contexts present in that repo. I'll redo this a bit... |
martinpitt
marked this pull request as draft
September 6, 2025 12:42
allisonkarlitskaya
added a commit
that referenced
this pull request
Sep 4, 2026
This supports triggering by wildcard patterns in either the bots repository or individual project repositories. Special care has to be given to our treatment of branches here: lib/testmap.py has a longstanding `# FIXME` noting that when checking the validity of a context we accept *any* branch as long as it's the correct project. That's because project-style contexts (like 'debian-trixie' or 'arch/other') don't specify a branch. That's not a problem when you're manually triggering, because we assume that the user knows which test they want, but for wildcards we need to limit ourselves to the correct branch. Add a `--branch` argument which does that, only for this specific case. This can also be used with the `--repo` argument when specifying a specific repo. For triggers from the bots repository we have the branch as part of the context (like `rhel-8-10/other@cockpit-project/cockpit/rhel-8`) and can filter on that via the wildcard either by specifying the branch or (in the case of main) excluding it. --branch is not considered at all in this case. This is consistent because when invoking tests in the bots repo, `--repo` is already `cockpit-project/bots` and we don't have an additional `--target-repo` option (nor do we want to add one), so having `--branch` mean `--target-branch` in this case would just be confusing and inconsistent: it doesn't make sense to filter by branch when you can't even filter by repo, and in any case, wildcards let you do both. Closes #8129
allisonkarlitskaya
added a commit
that referenced
this pull request
Sep 4, 2026
This supports triggering by wildcard patterns in either the bots repository or individual project repositories. Special care has to be given to our treatment of branches here: lib/testmap.py has a longstanding `# FIXME` noting that when checking the validity of a context we accept *any* branch as long as it's the correct project. That's because project-style contexts (like 'debian-trixie' or 'arch/other') don't specify a branch. That's not a problem when you're manually triggering, because we assume that the user knows which test they want, but for wildcards we need to limit ourselves to the correct branch. Add a `--branch` argument which does that, only for this specific case. This can also be used with the `--repo` argument when specifying a specific repo. For triggers from the bots repository we have the branch as part of the context (like `rhel-8-10/other@cockpit-project/cockpit/rhel-8`) and can filter on that via the wildcard either by specifying the branch or (in the case of main) excluding it. --branch is not considered at all in this case. This is consistent because when invoking tests in the bots repo, `--repo` is already `cockpit-project/bots` and we don't have an additional `--target-repo` option (nor do we want to add one), so having `--branch` mean `--target-branch` in this case would just be confusing and inconsistent: it doesn't make sense to filter by branch when you can't even filter by repo, and in any case, wildcards let you do both. Closes #8129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be helpful if you want to trigger something like '/networking@', for example.