-
Notifications
You must be signed in to change notification settings - Fork 477
Add docs: cockroach debug pebble db analyze-data
#22257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs: cockroach debug pebble db analyze-data
#22257
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
ee3f4ff to
9906554
Compare
9906554 to
47a2e4d
Compare
|
@RaduBerinde I think this captures the basic UX info etc from the google doc and Loom you shared. Please let me know if it is missing any important info or has inaccuracies, happy to update. Also, q for you and @dshjoshi - I wasn't sure whether / if to say much about how best for users to approach this tool. Is the idea that they'd be working with us via Support or their assigned SEs to analyze their workloads? I would imagine most users should do this in concert with someone from CRL so they can give us feedback on possible adaptive compression designs etc? (If i read some of the internal docs right). But please let me know what you think! |
RaduBerinde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Correct. The data is generally useful to us just to make further improvements, and it can also help inform changing the compression algorithm in a specific cluster. There are other things that factor into that decision (e.g. how much CPU usage headroom there is), so ideally CRL helps with that decision. |
ok thanks Radu! i guess this is somewhat covered under the 'Use cases' section where we say
so for now I'll leave it at that, but we can update it as needed with more words if we encounter situations where customers need clarification thank you for the review! |
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending suggestion and question.
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional suggestions
|
thanks for the reviews! merging now ... |
Fixes DOC-15817