feat(theme): add light/dark/system theme toggle#29
Merged
FreekBes merged 2 commits intoJun 24, 2026
Conversation
The dark theme was only driven by @media (prefers-color-scheme: dark). On Chromium-based browsers on Linux (e.g. Edge) the reported color scheme is the browser's own appearance setting, not the OS one, so a machine set to dark at the GNOME level could still render the light theme with no way for the user to override it. Add a header toggle that cycles System -> Light -> Dark, persists the choice in localStorage, and is resolved by an inline <head> script before first paint (no flash of the wrong theme). The script writes a concrete data-theme onto <html>; CSS now keys forced dark off :root[data-theme="dark"], while the prefers-color-scheme blocks remain as a no-JS fallback scoped to :root:not([data-theme]).
FreekBes
approved these changes
Jun 24, 2026
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
FreekBes
pushed a commit
to CheapFuck/codamhero-v2
that referenced
this pull request
Jun 24, 2026
# [2.4.0](codam-coding-college/codamhero-v2@v2.3.3...v2.4.0) (2026-06-24) ### Features * **theme:** add light/dark/system theme toggle ([codam-coding-college#29](codam-coding-college#29)) ([960cfd6](codam-coding-college@960cfd6))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dark theme was only driven by @media (prefers-color-scheme: dark). On Chromium-based browsers on Linux (e.g. Edge) the reported color scheme is the browser's own appearance setting, not the OS one, so a machine set to dark at the GNOME level could still render the light theme with no way for the user to override it.
Add a header toggle that cycles System -> Light -> Dark, persists the choice in localStorage, and is resolved by an inline script before first paint (no flash of the wrong theme). The script writes a concrete data-theme onto ; CSS now keys forced dark off :root[data-theme="dark"], while the prefers-color-scheme blocks remain as a no-JS fallback scoped to :root:not([data-theme]).