Remove unused DurationBeforeChangeTierRequestDeletion config

[rajivnathan]

https://issues.redhat.com/browse/SANDBOX-1647

Description

The DurationBeforeChangeTierRequestDeletion is no longer used.

Checks

1. Did you run make generate target? yes

2. Did make generate change anything in other projects (host-operator, member-operator)? yes

3. In case of new CRD, did you the following? no

   • make/generate.mk in this repository
   • resources/setup/roles/host.yaml in the sandbox-sre repository
   • PROJECT file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECT
   • CSV file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yaml

4. In case other projects are changed, please provides PR links.

   • host-operator: Remove unused DurationBeforeChangeTierRequestDeletion config host-operator#1239
   • toolchain-common: Remove unused DurationBeforeChangeTierRequestDeletion config toolchain-common#515
   • member-operator: Remove unused DurationBeforeChangeTierRequestDeletion config member-operator#730
   • registration-service: Remove unused DurationBeforeChangeTierRequestDeletion config registration-service#578
   • toolchain-e2e: Remove unused DurationBeforeChangeTierRequestDeletion config toolchain-e2e#1258

Summary by CodeRabbit

• Chores
  • Removed the configuration option for tier change request deletion duration timing from tier settings.

[coderabbitai]

Walkthrough

The DurationBeforeChangeTierRequestDeletion field is removed from the TiersConfig type across its type definition, deepcopy handler, and OpenAPI schema representation.

Changes

Cohort / File(s)	Summary
TiersConfig field removal api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/zz_generated.deepcopy.go, api/v1alpha1/zz_generated.openapi.go	Removes DurationBeforeChangeTierRequestDeletion field from TiersConfig struct definition, its deepcopy handler logic, and OpenAPI schema entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: removing an unused configuration field from the API.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description includes all required sections with completed information: a clear description of the change, affirmative responses to checks 1-2, and PR links to related projects.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rajivnathan]

The verify-dependencies job error is about toolchain-common:

Error: /home/runner/go/pkg/mod/github.com/codeready-toolchain/toolchain-common@v0.0.0-20260108130331-10ca562525fe/pkg/test/config/toolchainconfig.go:591:26: config.Spec.Host.Tiers.DurationBeforeChangeTierRequestDeletion undefined (type "github.com/codeready-toolchain/api/api/v1alpha1".TiersConfig has no field or method DurationBeforeChangeTierRequestDeletion)

I'll merge codeready-toolchain/host-operator#1240 first, then codeready-toolchain/toolchain-common#516 and then hopefully the verify-dependencies job here will not complain