Conversation
Pass ignore_errors=False to shutil.rmtree so OS errors propagate to the try/except in delete(), allowing failed directory deletions to correctly return -1 instead of 1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When Anchored.short (or any adapter) transforms a path to "", the empty string was still appended to result and joined, producing extra delimiters in the output. Add an early `continue` to skip empty strings after adapter transformation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
In run()'s dryrun early-return, result.error was initialized to "" only when stdout was captured (duplicate condition), never when stderr was captured. Change the second condition to check stderr. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
COLUMNS can make short() truncate expected full strings and cause spurious failures.
zsimic
approved these changes
Sep 10, 2026
zsimic
left a comment
zsimic
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Quite a few bugs! Some are unclear why they were bugs, but willing to trust :) Looks likely legit for those too
|
|
||
| else: | ||
| shutil.rmtree(path, ignore_errors=not fatal) | ||
| shutil.rmtree(path, ignore_errors=False) |
Collaborator
There was a problem hiding this comment.
What was wrong with not fatal?
|
|
||
| if stdout is not None: | ||
| if stderr is not None: | ||
| result.error = "" |
Collaborator
There was a problem hiding this comment.
I need to change this so result.error = "" all the time... there's not much value actually to have this as str | None, but this kind of ok (it should really be if stdout is not None or stderr is not None or is_passthrough... (it's the gist of it -> not None if there was anything captured)
| def canonical_platform(name): | ||
| name = name and name.lower() | ||
| if not name: | ||
| return name |
Collaborator
There was a problem hiding this comment.
OK but seems not needed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.