Fix Python Trino quickstart catalog typo and macOS install step#112
Open
prabhacloud wants to merge 1 commit into
Open
Fix Python Trino quickstart catalog typo and macOS install step#112prabhacloud wants to merge 1 commit into
prabhacloud wants to merge 1 commit into
Conversation
- Correct the URI catalog parameter from `tcph` to `tpch`. The example query still ran because the table was fully qualified, but the default catalog in the connection string was wrong. - Update the install command to `dbc install trino --level user` so the driver is placed in a path the ADBC driver manager searches by default. Addresses the dlopen failure reported in columnar-tech#96. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalog=tcph→catalog=tpchtypo inpython/trino/main.py. The example worked only because the SELECT fully qualifies the table; a user copying the URI and running an unqualified query would hit a confusing "catalog not found" error.python/trino/README.mdto recommenddbc install trino --level user, matching the workaround that resolved Issues running Trino/Python example on MacOS #96 (macOS dlopen failure when the driver is installed at the default level).Test plan
uv run python/trino/main.pyagainst a localtrinodb/trinoDocker container returns the 5 TPC-H nation rows.dbc install trino --level userlands the driver in a path the ADBC driver manager searches without settingADBC_DRIVER_PATH.