fix(workspace): disambiguate docs package and document local setup - #472
kim-benedict wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe changes add contributor setup and workflow guidance, link to it from repository documentation and the comark README, rename the documentation-site package, and update the expected published comark package size. ChangesRepository guidance and maintenance
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The contributor guidance and package rename show no established blocker to merging after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@kim-benedict is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
Note This drawing shows
✅ Clean pass · drawing Architecture Data flow No data-flow sequence changed in this PR. View
Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
c9a7aad to
f067c12
Compare
What
Give the docs app a unique, private package name so
pnpm --filter comarkselects only the parser. Add a contributor guide covering source stubs, examples, plugins, checks and signed commits, and link it from the README. Update the bundle snapshot for the README addition.Why
The docs app shares the parser's name, so a focused parser test passes and then fails when pnpm also runs it in docs. #147 reports missing setup guidance; the guide explains the current stub-based workflow and when compiler watchers are useful.
Related #147. The separate Nuxt playground request remains outside this PR.
Validation
Checked with Node 24.21.0 and pnpm 12.5.1:
pnpm install --frozen-lockfilepasses without lockfile changes.pnpm --filter comark exec vitest run test/parse/sub-sup.test.tscommand now runs only inpackages/comarkand passes all 3 tests.pnpm verifypasses: lint, 2,123 package tests and typecheck.pnpm prepackand the updated bundle snapshot check pass;pnpm stubrestores source exports afterward.The first verification run hit a 10ms timeout in an unchanged Markdown fixture; both subsequent full runs passed.
Summary by CodeRabbit