Open
Conversation
Member
|
Thank you for submitting. the design goal of shortname originates from the original getopt parser... you cant have a -FS if you have -F and a -S because how does the parser distinguish? if you want a short version of --FileSystem then create --FS option. IMO I dont feel like this is a good move. It could be argued to try to match Longest shortName first. but then there needs to be conflict reporting if a user creates This adds a whole bunch of need for testing/conflict resolution and reporting logic to be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
OptionAttributehave a limitation of shortName being able to be set to just one character. This creates a limitation in the functionality of giving more readable or rememberable short names. For example, -FileSystem can be made to -FS.This PR tends to address this limitation.
PS: this my first PR with this repository, let me know if more test cases have to be added.
Issue #752