Fix #830 - Recognize Option, Value and Usage attributes on private members#831
Open
Saalvage wants to merge 2 commits intocommandlineparser:masterfrom
Open
Fix #830 - Recognize Option, Value and Usage attributes on private members#831Saalvage wants to merge 2 commits intocommandlineparser:masterfrom
Saalvage wants to merge 2 commits intocommandlineparser:masterfrom
Conversation
Member
|
The point of the Options class was only to hold the parser results. Its a single-use design, that implies you have the ability to make public all options so the parser can apply parsed items from the commandline. I'm a little dubious on making the change but since it doesnt actually hurt anything it'll probably go through And BTW, thank you for also submitting the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential use cases:
init/set-only properties unnecessarily, as usage of the Options class from a programming interface should not rely on the parsing and instead assign the parsed properties directly.Usagefunctionality to the programming interface.Additional arguments:
init/seton a public property, so this seems more like an oversight (or the other way around!)