Fix #777: Treat Objects with Init Properties as Immutable#949
Open
rjkovach wants to merge 4 commits intocommandlineparser:developfrom
Open
Fix #777: Treat Objects with Init Properties as Immutable#949rjkovach wants to merge 4 commits intocommandlineparser:developfrom
rjkovach wants to merge 4 commits intocommandlineparser:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
ReflectionExtensions.IsMutable()looks for public properties on an object which are writable to determine whether it is mutable. However, this logic does not account for other common immutable patterns like private setters or the newer init-only properties. This change adds support for both of these patterns.Adding this support also adds support for using C# 9 record types, which are immutable by default, as options types.
Adds new tests for the various immutable patterns as well as parsing arguments to record types.
Fix #777.