Skip to content

Home

Jump to bottom
Robin Herberich edited this page Dec 19, 2024 · 61 revisions

Code Review Process Guidelines :

  • Function-specific comments
  • Sensical Variable Names (variable names) using camel case
  • Clean git comments
  • Overall comment
  • Major and minor issues
  • Future Improvements

Pull Request Standard :

Each person’s assigned reviewer (weekly alternation)

S1

Reviewee Reviewer Reviewer
Paul Alejandro Ricardo
Alex Paul Alejandro
Mateus Alex Paul
Kevin Mateus Alex
Robin Kevin Mateus
Ricardo Robin Kevin
Alejandro Ricardo Robin

S2

Reviewee Reviewer Reviewer
Alex Alejandro Paul
Mateus Paul Alex
Kevin Alex Mateus
Robin Mateus Kevin
Ricardo Kevin Robin
Alejandro Robin Ricardo
Paul Ricardo Alejandro

S3

Reviewee Reviewer Reviewer
Mateus Alejandro Paul
Kevin Paul Alex
Robin Alex Mateus
Ricardo Mateus Kevin
Alejandro Kevin Robin
Paul Robin Ricardo
Alex Ricardo Alejandro

S4

Reviewee Reviewer Reviewer
Mateus Ricardo Alejandro
Kevin Alejandro Paul
Robin Paul Alex
Ricardo Alex Mateus
Alejandro Mateus Kevin
Paul Kevin Robin
Alex Robin Ricardo

S5

Reviewee Reviewer Reviewer
Mateus Robin Ricardo
Kevin Ricardo Alejandro
Robin Alejandro Paul
Ricardo Paul Alex
Alejandro Alex Mateus
Paul Mateus Kevin
Alex Kevin Robin

S6

Reviewee Reviewer Reviewer
Mateus Kevin Robin
Kevin Robin Ricardo
Robin Ricardo Alejandro
Ricardo Alejandro Paul
Alejandro Paul Alex
Paul Alex Mateus
Alex Mateus Kevin

S7

Reviewee Reviewer Reviewer
Mateus Paul Alex
Kevin Alex Mateus
Robin Mateus Kevin
Ricardo Kevin Robin
Alejandro Robin Ricardo
Paul Ricardo Alejandro
Alex Alejandro Paul

S8

Reviewee Reviewer Reviewer
Mateus Alejandro Kevin
Kevin Paul Robin
Robin Alex Ricardo
Ricardo Mateus Alejandro
Alejandro Kevin Paul
Paul Robin Alex
Alex Ricardo Mateus

S9

Reviewee Reviewer Reviewer
Mateus Ricardo Robin
Kevin Alejandro Ricardo
Robin Paul Alejandro
Ricardo Alex Paul
Alejandro Mateus Alex
Paul Kevin Mateus
Alex Robin Kevin

S10

Reviewee Reviewer Reviewer
Mateus Robin Ricardo
Kevin Ricardo Alejandro
Robin Alejandro Paul
Ricardo Paul Alex
Alejandro Alex Mateus
Paul Mateus Kevin
Alex Kevin Robin

Branch Naming Convention :

feature/feature-name, bugfix/issue-number

Stand Up Meeting Frequency & Location :

Mondays 11:00 Wednesdays 13:00 Fridays 10:00

Scrum Master Rotation:

Interpersonal relations and keep a good relation in the team.

S1 Paul
S2 Alex
S3 Alejandro
S4 Ricardo
S5 Robin
S6 Kevin
S7 Mateus
S8 Paul
S9 Alex
S10 Alejandro
S11 Ricardo

Product Owner Rotation:

Role : Push people to work and organize tasks around on the scrum board.

S1 Mateus
S2 Kevin
S3 Robin
S4 Alejandro
S5 Ricardo
S6 Alex
S7 Paul
S8 Mateus
S9 Kevin
S10 Robin
S11 Ricardo

TestTags for UI components Guidelines :

  • Camel case
  • One word
  • Format its name as “ScreenNameComponent” (example: “AddFoodItemExpiryDate”)

Coach meetings notes

  • Scrum Master has to show main branch
  • Scrum Master has to go through the project kollabe and explain how issues were addressed

3 Milestones (email w/ information sent over the wk) :

Milestone 1

Stand-Up Minutes: https://docs.google.com/spreadsheets/d/18YvkoCJspsIxQ5-G66ltyhTTZsJAQiF1h9PdHqk_CyQ/edit?usp=sharing

Team Retrospective: https://docs.google.com/spreadsheets/d/1mW-e6UOw1bEw6MQPCf294cT8WwfMWOr3ZHcXyPEOE1w/edit?usp=sharing

Personal retrospective

Note 1 :

The apk of the app can be found in the release directory of the repo

Note 2 :

For apk creation and release there is now a release_apk script on the repo that can be called by anyone (it requires adb). There is also a github workflow that can be called to create on directly on the repo.

Figma

https://www.figma.com/design/05FWkNY6XZhuBZN2ADIumq/Shelf-Life?version-id=6876781832&node-id=0-1&node-type=canvas&t=jqTjvWz6JehEQ3Fg-0

Milestone 2

Stand-Up Minutes: https://docs.google.com/spreadsheets/d/1noDu2u93xO7_P0Hqe6qiwDceJdq-GJLvMHrGYl8ADlA/edit?usp=sharing

Team retrospective: https://docs.google.com/spreadsheets/d/1ivlbFTW85W8zXvD_dj-s67_leNVPXLAGWYiMRfEqjFI/edit?usp=sharing

Personal retrospective

Figma: https://www.figma.com/design/05FWkNY6XZhuBZN2ADIumq/Shelf-Life?version-id=2150949089645394636&node-id=0-1&node-type=canvas&t=Yd38BkrkWfjXQD6K-0

Note 1 :

The apk of the app can be found inside the release named M2, do not use the apk inside the releases folder of the repo, it contains an old version.

Note 2 :

For apk creation and release there is now a release_apk script on the repo that can be called by anyone (it requires adb). There is also a github workflow that can be called to create on directly on the repo.

Milestone 3

Stand-Up Minutes: https://docs.google.com/spreadsheets/d/18lBpYIEl8rLBGrPu1dzs1yYYP7rjHV1K0nBtF2MJ3QI/edit?gid=2093936121#gid=2093936121

Team retrospective: https://docs.google.com/spreadsheets/d/1ivlbFTW85W8zXvD_dj-s67_leNVPXLAGWYiMRfEqjFI/edit?usp=sharing

Personal retrospective

Note 1 :

The apk of the app can be found inside the release named M3.

Clone this wiki locally