Skip to content

Incus: read storage names from .vars files - #110

Merged
MickLesk merged 2 commits into
mainfrom
fix/storage-from-vars
Oct 6, 2026
Merged

MickLesk merged 2 commits into
mainfrom
fix/storage-from-vars

Conversation

@MickLesk

@MickLesk MickLesk commented Oct 6, 2026

Copy link
Copy Markdown
Member

✍️ Description

1.) Read storage names from .vars files the way load_vars_file does
Both platforms took var_template_storage and var_container_storage with grep|cut, so a quoted value (var_container_storage="local-zfs") or an inline comment became part of the storage name.

2.) take var_container_storage from the run and ask for one pool only
Generated runs ignored var_container_storage and stopped at a pool menu on hosts with more than one pool, and the defaults flow also asked for a template pool, which Incus does not have.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

Both platforms took var_template_storage and var_container_storage with grep|cut, so a quoted value (var_container_storage="local-zfs") or an inline comment became part of the storage name.
Generated runs ignored var_container_storage and stopped at a pool menu on hosts with more than one pool, and the defaults flow also asked for a template pool, which Incus does not have.
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-vars \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches incus/, so it needs an Incus host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-vars/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-vars

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit b81c93c into main Oct 6, 2026
4 checks passed
@MickLesk
MickLesk deleted the fix/storage-from-vars branch October 6, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant