Repository navigation
Incus: read storage names from .vars files - #110
Merged
Merged
Conversation
Both platforms took var_template_storage and var_container_storage with grep|cut, so a quoted value (var_container_storage="local-zfs") or an inline comment became part of the storage name.
Generated runs ignored var_container_storage and stopped at a pool menu on hosts with more than one pool, and the defaults flow also asked for a template pool, which Incus does not have.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-vars \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-vars/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/storage-from-varsNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
1.) Read storage names from .vars files the way load_vars_file does
Both platforms took var_template_storage and var_container_storage with grep|cut, so a quoted value (var_container_storage="local-zfs") or an inline comment became part of the storage name.
2.) take var_container_storage from the run and ask for one pool only
Generated runs ignored var_container_storage and stopped at a pool menu on hosts with more than one pool, and the defaults flow also asked for a template pool, which Incus does not have.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.