Skip to content

Keep setup_nodejs alive when the caller's directory is gone - #114

Merged
MickLesk merged 1 commit into
mainfrom
fix/npm-missing-cwd
Oct 7, 2026
Merged

MickLesk merged 1 commit into
mainfrom
fix/npm-missing-cwd

Conversation

@MickLesk

@MickLesk MickLesk commented Oct 7, 2026

Copy link
Copy Markdown
Member

✍️ Description

Nginx Proxy Manager builds OpenResty in a directory it then deletes, so npm started in a cwd that no longer existed and died with uv_cwd (exit 7). The npm upgrade handled that as a warning, but 072081e read the npm major with a bare assignment, which pipefail turned into a fatal error; the error handler then blamed the earlier npm upgrade (ProxmoxVE#17735).

Move the cd /opt guard ahead of the first npm call, let the npm_major assignment fail quietly, and clear the silent-failure state once _setup_npm has handled it.

🔗 Related Issue

Fixes community-scripts/ProxmoxVE#17735

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

Nginx Proxy Manager builds OpenResty in a directory it then deletes, so npm
started in a cwd that no longer existed and died with uv_cwd (exit 7). The
npm upgrade handled that as a warning, but 072081e read the npm major with a
bare assignment, which pipefail turned into a fatal error; the error handler
then blamed the earlier npm upgrade (ProxmoxVE#17735).

Move the cd /opt guard ahead of the first npm call, let the npm_major
assignment fail quietly, and clear the silent-failure state once _setup_npm
has handled it.
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/npm-missing-cwd \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/npm-missing-cwd/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/npm-missing-cwd

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit 0feec7a into main Oct 7, 2026
5 checks passed
@github-actions
github-actions Bot deleted the fix/npm-missing-cwd branch October 7, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Nginx Proxy Manager] Error during install

1 participant