Skip to content

PVE: Smart Diagnosis - say why a container would not start - #95

Merged
MickLesk merged 2 commits into
mainfrom
fix/ct-start-diagnostics
Oct 5, 2026
Merged

MickLesk merged 2 commits into
mainfrom
fix/ct-start-diagnostics

Conversation

@MickLesk

@MickLesk MickLesk commented Oct 5, 2026

Copy link
Copy Markdown
Member

✍️ Description

pct start reports only that the startup failed; lxc writes the reason to the container's journal, which nothing read. 80 failed starts a week reached the telemetry as "failed to start" and nothing else.

A failed start, a container that never reaches running, and a failed restart after a config change now show the journal of that start attempt and append it to the build log, whose tail the telemetry sends.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

pct start reports only that the startup failed; lxc writes the reason
to the container's journal, which nothing read. 80 failed starts a week
reached the telemetry as "failed to start" and nothing else.

A failed start, a container that never reaches running, and a failed
restart after a config change now show the journal of that start
attempt and append it to the build log, whose tail the telemetry sends.
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/ct-start-diagnostics \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches pve/, so it needs a Proxmox VE host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/ct-start-diagnostics/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/ct-start-diagnostics

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit e3c2809 into main Oct 5, 2026
4 checks passed
@github-actions
github-actions Bot deleted the fix/ct-start-diagnostics branch October 6, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant