Skip to content

ci: share one platform run across matrix jobs via --run-key - #283

Merged
HeyGarrison merged 2 commits into
masterfrom
devin/run-key-matrix
Aug 5, 2026
Merged

ci: share one platform run across matrix jobs via --run-key#283
HeyGarrison merged 2 commits into
masterfrom
devin/run-key-matrix

Conversation

@HeyGarrison

@HeyGarrison HeyGarrison commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Updates the matrix benchmark workflows to pass a shared RUN_KEY (${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}) to every bench run invocation, so all provider matrix jobs for a given workflow run join the same platform run. runKey is still scoped by benchmark slug, so distinct slugs (e.g. TTI shapes) still get distinct runs.

  • snapshot-fork-benchmarks.yml
  • browser-benchmarks.yml
  • browser-throughput-benchmarks.yml
  • sandbox-dax-benchmarks.yml
  • storage-benchmarks.yml: storage.bench.ts hardcodes benchmarkSlug: 'storage-local', so RUN_KEY also includes the matrix FILE_SIZE to keep each file size in its own run while still grouping all providers per size.

Skipped:

  • sandbox-tti-benchmarks.yml — already passes --run-key.
  • ai-gateway-benchmarks.yml — deliberately a single job (no matrix) per its own comment.
  • git-benchmarks.yml — not present in this repository.

Note: pnpm typecheck currently fails on benchmarks/sandbox/tti.bench.ts(64,3) (shapes not in BenchmarkConfig) on master as well, so that failure is pre-existing and unrelated to these workflow changes.

Link to Devin session: https://app.devin.ai/sessions/303937628eab4d9f874312edc3a02b88
Requested by: @HeyGarrison


Open in Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@HeyGarrison HeyGarrison self-assigned this Aug 5, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@open-cla

open-cla Bot commented Aug 5, 2026

Copy link
Copy Markdown

Contributor License Agreement

All contributors are covered by a CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/storage-benchmarks.yml Outdated
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@HeyGarrison
HeyGarrison merged commit 743e5b3 into master Aug 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant