ci: share one platform run across matrix jobs via --run-key - #283
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor License AgreementAll contributors are covered by a CLA. |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the matrix benchmark workflows to pass a shared
RUN_KEY(${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}) to everybench runinvocation, so all provider matrix jobs for a given workflow run join the same platform run.runKeyis still scoped by benchmark slug, so distinct slugs (e.g. TTI shapes) still get distinct runs.snapshot-fork-benchmarks.ymlbrowser-benchmarks.ymlbrowser-throughput-benchmarks.ymlsandbox-dax-benchmarks.ymlstorage-benchmarks.yml:storage.bench.tshardcodesbenchmarkSlug: 'storage-local', soRUN_KEYalso includes the matrixFILE_SIZEto keep each file size in its own run while still grouping all providers per size.Skipped:
sandbox-tti-benchmarks.yml— already passes--run-key.ai-gateway-benchmarks.yml— deliberately a single job (no matrix) per its own comment.git-benchmarks.yml— not present in this repository.Note:
pnpm typecheckcurrently fails onbenchmarks/sandbox/tti.bench.ts(64,3)(shapesnot inBenchmarkConfig) onmasteras well, so that failure is pre-existing and unrelated to these workflow changes.Link to Devin session: https://app.devin.ai/sessions/303937628eab4d9f874312edc3a02b88
Requested by: @HeyGarrison