feat(storage): wire up Neon Object Storage adapter - #284
Merged
Conversation
Co-Authored-By: Noah Kiser <noah@computesdk.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Noah Kiser <noah@computesdk.com>
kisernl
marked this pull request as ready for review
August 7, 2026 15:54
Contributor License AgreementAll contributors are covered by a CLA. |
…lows Co-Authored-By: Noah Kiser <noah@computesdk.com>
Contributor
|
Addressed the review comments in
Verification:
|
Contributor
Storage Benchmark Results1MB Files
View full run · SVGs available as build artifacts |
Contributor
Browser Benchmark Results
View full run · SVG available as build artifact |
Contributor
Snapshot/Fork Benchmark Resultssmall dataset
|
Contributor
Browser Throughput Benchmark Results
View full run · SVG available as build artifact |
Contributor
Sandbox Benchmark ResultsSequential
Staggered
Burst
View full run · SVGs available as build artifacts |
Contributor
Sandbox Dax Benchmark Results
|
Contributor
AI Gateway Benchmark Results
View full run · SVG available as a build artifact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the new
@storagesdk/adapters/neonadapter into the storage and snapshot/fork benchmarks.neonparticipant tobenchmarks/storage/providers.tswithNEON_BUCKET,NEON_ENDPOINT,NEON_ACCESS_KEY_ID, andNEON_SECRET_ACCESS_KEY(plus optionalNEON_REGION). It reuses the S3-compatible adapter for snapshot/fork, with optionalNEON_SNAPSHOT_*overrides that fall back to the upload/download creds.bench:storage:neonandbench:snapshot-fork:neonscripts.neonto the storage and snapshot/fork benchmark matrices and vault-secret loader regexes.benchmarks/scripts/provider-vars.jsonwith the Neon env var set.@storagesdk/adaptersto^0.11.0(the pending minor release that shipsneon).This PR is ready for review but depends on
@storagesdk/adapters@0.11.0being published; once it is, runpnpm installto updatepnpm-lock.yamlbefore merging.Link to Devin session: https://app.devin.ai/sessions/98223325d0664503bdea8a4f71ada5f5