Skip to content

fix(sandbox): make DAX disk metrics portable - #288

Open
SystemSculpt wants to merge 1 commit into
computesdk:masterfrom
SystemSculpt:fix/dax-busybox-disk-accounting
Open

fix(sandbox): make DAX disk metrics portable#288
SystemSculpt wants to merge 1 commit into
computesdk:masterfrom
SystemSculpt:fix/dax-busybox-disk-accounting

Conversation

@SystemSculpt

Copy link
Copy Markdown

Summary

  • replace GNU-only du --block-size=1 with du -skx
  • convert KiB to bytes so the DAX result format stays unchanged

Why

BusyBox du rejects --block-size=1. The benchmark continues, but its disk fields are missing.

Verification

  • pnpm typecheck
  • pnpm -r --if-present test (184 passed, 1 skipped)
  • actionlint -ignore 'string should not be empty' -shellcheck=
  • bash -n benchmarks/scripts/dax-benchmark.sh
  • ShellCheck on the changed script, excluding the two unchanged warnings already on master
  • real Blaxel DAX run with this fix and fix(sandbox): isolate Blaxel DAX runtime #272: 7/7 phases, three populated disk values, zero cleanup residue

Signed-off-by: Michael Stolarz <146425971+SystemSculpt@users.noreply.github.com>
@SystemSculpt
SystemSculpt marked this pull request as ready for review August 7, 2026 18:11
@open-cla

open-cla Bot commented Aug 7, 2026

Copy link
Copy Markdown

Contributor License Agreement

All contributors are covered by a CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant