Fix container notch and move control disappearing after a move - #408
Merged
aembler merged 1 commit intoAug 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes concretecms/concretecms#12353.
When you move a container, its title notch and move control vanish until you reload the page. That's the first bug below. While I was in here I also fixed a related one where the move handle stays put but stops responding to clicks.
The notch disappears when you move a block.
Block.move()calledmy.getContainer().remove()and then, for a non-wrapping block, re-inserted only the inner element — so the container wrapper that carries the notch (and its move control) got thrown away. Now the wrapper is captured up front anddetach()ed instead, so it survives the move and goes back in as a unit.The drag handle stops responding. The ConcreteMenu click-proxy overlay (z-index 500) could end up painted over the notch's move handle, swallowing the mousedown so pep never starts a drag. Two parts:
bindNotchMenu()clears stale.concreteMenuhandlers that pile up across drag cycles (ContainerBlock and Layout don't keep a reference to their menu, so it isn't torn down onscanBlocksreset), and the move handle getsposition: relative; z-index: 501so it paints above the proxy.Both show up on plain within-area sorting — bug 1 is the exact repro in the issue.