Skip to content

krun: request enabling DHCP client #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giuseppe merged 2 commits into from
May 26, 2026
+14 −2
Merged

krun: request enabling DHCP client #2093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e521de6
krun: check krun_add_net_unixstream dlsym
slp May 18, 2026
535e114
krun: request enabling DHCP client
slp May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/libcrun/handlers/krun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@
# include <libkrun.h>
#endif

/* This allows us to build even with headers from older libkrun versions.
* If the installed version of libkrun doesn't support this feature,
* krun_add_net_unixstream() will return EINVAL.
*/
#ifndef NET_FLAG_DHCP_CLIENT
# define NET_FLAG_DHCP_CLIENT (1 << 1)
#endif

/* libkrun has a hard-limit of 16 vCPUs per microVM. */
#define LIBKRUN_MAX_VCPUS 16

Expand Down Expand Up @@ -297,11 +305,15 @@ libkrun_configure_vm (uint32_t ctx_id, void *handle, struct krun_config *kconf,
if (kconf->use_passt)
{
krun_add_net_unixstream = dlsym (handle, "krun_add_net_unixstream");
if (krun_add_net_unixstream == NULL)
return crun_make_error (err, 0, "could not find symbol `krun_add_net_unixstream` in the krun library");

uint8_t mac[] = { 0x5a, 0x94, 0xef, 0xe4, 0x0c, 0xee };
ret = krun_add_net_unixstream (ctx_id, NULL, kconf->passt_fds[PASST_FD_PARENT], &mac[0], COMPAT_NET_FEATURES, 0);
ret = krun_add_net_unixstream (ctx_id, NULL, kconf->passt_fds[PASST_FD_PARENT], &mac[0], COMPAT_NET_FEATURES, NET_FLAG_DHCP_CLIENT);
Comment thread
slp marked this conversation as resolved.
Comment thread
slp marked this conversation as resolved.
if (UNLIKELY (ret == -EINVAL))
ret = krun_add_net_unixstream (ctx_id, NULL, kconf->passt_fds[PASST_FD_PARENT], &mac[0], COMPAT_NET_FEATURES, 0);
if (UNLIKELY (ret < 0))
error (EXIT_FAILURE, -ret, "could not set krun net configuration");
return crun_make_error (err, -ret, "could not set krun net configuration");
Comment thread
slp marked this conversation as resolved.
}

if (kconf->config_tree != NULL)
Expand Down
Loading