Bump to v0.15.0 #2212
Bump to v0.15.0 #2212
Conversation
Signed-off-by: Oliver Walsh <[email protected]>
olliewalsh
requested review from
bmahabirbu,
cgruver,
engelmi,
jhjaggars,
maxamillion,
rhatdan and
swarajpande5
as code owners
Reviewer's GuideBumps RamaLama to version 0.15.0 across code, packaging, and docs, while expanding configuration documentation (env, logging, RAG images, and user preferences) and adding a new macOS installation guide manpage-derived doc. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @olliewalsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine version update to 0.15.0, ensuring all internal and external references are consistent. Alongside this, it enhances the project's configurability by introducing new settings and significantly improves user experience for macOS users with a detailed installation and usage guide. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In
conf.mdx, the**rag_format**="qdrant"key now has a description that talks about the RAG OCI image andrag_images, which looks like a copy/paste error; either the heading or the description should be adjusted sorag_formatandrag_imagesare documented separately and clearly. - The new
log_leveloption description inconf.mdxhas a minor typo/formatting issue in the valid values list (error critical), which should likely readerror, criticalfor consistency with the others.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `conf.mdx`, the `**rag_format**="qdrant"` key now has a description that talks about the RAG OCI image and `rag_images`, which looks like a copy/paste error; either the heading or the description should be adjusted so `rag_format` and `rag_images` are documented separately and clearly.
- The new `log_level` option description in `conf.mdx` has a minor typo/formatting issue in the valid values list (`error critical`), which should likely read `error, critical` for consistency with the others.
## Individual Comments
### Comment 1
<location> `docsite/docs/configuration/conf.mdx:136-137` </location>
<code_context>
Pass `--group-add keep-groups` to podman, when using podman.
In some cases this is needed to access the gpu from a rootless container
+**log_level**=warning
+Set the logging level of RamaLama application.
+Valid Values:
+ debug, info, warning, error critical
+:::note
+ --debug option overrides this field and forces the system to debug
</code_context>
<issue_to_address>
**issue (typo):** Fix logging level list formatting to include a comma between `error` and `critical`.
The list of valid values is missing a comma between `error` and `critical`. Please update it to `debug, info, warning, error, critical` for clarity and consistency with standard logging level names.
```suggestion
Valid Values:
debug, info, warning, error, critical
```
</issue_to_address>
### Comment 2
<location> `docsite/docs/configuration/conf.mdx:175-177` </location>
<code_context>
**rag_format**="qdrant"
-Specify the default output format for output of the `ramalama rag` command
-Options: json, markdown, qdrant
+OCI container image to run with the specified AI model when using RAG content.
+
+**rag_images**="quay.io/ramalama/ramalama-rag"
</code_context>
<issue_to_address>
**issue:** The `rag_format` field description appears to describe images, not a format.
The header still shows `**rag_format**="qdrant"`, but the text now describes an OCI image, which fits `rag_images` instead. This suggests the original format-options description was overwritten. Please either restore the format options here, or rename this field if its meaning has actually changed.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version of RamaLama to 0.15.0 and updates the documentation and configuration files accordingly. The changes are mostly correct, but I've found a few minor issues in the documentation related to formatting and content placement that could impact clarity and rendering. My review includes suggestions to fix these issues.
Signed-off-by: Oliver Walsh <[email protected]>
|
LGTM |
2 participants
Summary by Sourcery
Bump RamaLama to version 0.15.0 and update configuration and macOS documentation accordingly.
Documentation:
Chores: