Pass supplemental groups when Podman is using crun#1647
Open
mwinters0 wants to merge 2 commits intocontainers:mainfrom
Open
Pass supplemental groups when Podman is using crun#1647mwinters0 wants to merge 2 commits intocontainers:mainfrom
mwinters0 wants to merge 2 commits intocontainers:mainfrom
Conversation
This solves the common issue where /dev/vboxusb/* is owned by group "vboxusers", causing volume mounts to fail when running `toolbox enter`. Same is true for any other mapped dirs with supplemental group owners. Signed-off-by: Michael Winters <1688867+mwinters0@users.noreply.github.com>
Author
|
I see that some of the Zuul tests are failing because they now see additional groups inside the container: I'm not able to address this because I don't really know what I'm doing with BATS: % bats ./test/system
1..1
not ok 1 bats-gather-tests
# bats_load_safe: Could not find '/home/mwinters/projects/forks/containers_toolbox/test/system/libs/bats-support/load'[.bash]
|
Signed-off-by: Michael Winters <1688867+mwinters0@users.noreply.github.com>
|
Oh any news on this? Isee our PRs seem to be related to each other. #1732 |
Author
|
I haven't had time to figure out how to satisfy the tests. I requested review 7 months ago, so I think the maintainers do not look at PRs unless the tests are passing. |
|
Maybe we can tag him for attention @debarshiray |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the common issue where
/dev/vboxusb/*is owned by groupvboxusers, causing volume mounts to fail when runningtoolbox enter. Same is true for any other mapped dirs with supplemental group owners. This is a common issue, frequently reported by its rather cryptic symptoms.Tested on Fedora Workstation 42.
Fixes #1589
Probably #1640
And maybe:
#1310
#1085
#569
Note:
Podman option
keep-groupswas created in containers/podman@e356160 and first released in v3.2.0 (2021-06-03).