refactor(ios): unify generation paths via GenerationSink protocol#30
Merged
Conversation
Collapse performGeneration and performGenerationWithEvents into a single engine parameterized by a GenerationSink. StringGenerationSink and EventGenerationSink each own their streaming specifics (token batching, thinking state machine, tool-call events, zero-width-space force-flush) while sharing the generation loop, tool-execution task group, and history management. Public API is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerationSinkprotocol withStringGenerationSinkandEventGenerationSinkimplementations, each owning the streaming concerns specific to its call site (token batching, thinking state machine, tool-call events, zero-width-space force-flush)performGenerationandperformGenerationWithEventsinto a single engine that drives the generation loop, tool-execution task group, and history management through the sinkgenerate,stream,streamWithEvents) is unchanged; behavior preserved includingfirstTokenTimesemantics,\u{200B}continuation marker (string-only), and thinking flush (event-only)Test plan
bun --cwd package build) with no compilation errorsgenerate(non-streaming) and confirm stats/output match prior behaviorstreamwith tool calls and verify the zero-width-space continuation marker still firesstreamWithEventsand verifythinking_start/thinking_chunk/thinking_endandtool_call_*events still emit correctly