Pass through bodyParser.json() middleware options#12
Open
mbland wants to merge 1 commit intocoreh:masterfrom
Open
Pass through bodyParser.json() middleware options#12mbland wants to merge 1 commit intocoreh:masterfrom
mbland wants to merge 1 commit intocoreh:masterfrom
Conversation
18F/pages is a Hookshot server for https://pages.18f.gov/. Recently, as noted in 18F/pages#14, the default 100KB payload limit was exceeded by a webhook fired for uswds/uswds#54. This change will allow us to pass options through to the bodyParser.json() middleware to increase the limit.
This was referenced Jun 22, 2015
Author
|
Ping... Any interest in merging this? |
mbland
pushed a commit
to 18F/hub
that referenced
this pull request
Aug 17, 2015
The public Hub push in #370 failed due to the webhook exceeding the default 100K limit, just as in 18F/pages#15. This applies the same fix as 18F/pages. Still waiting on coreh/hookshot#12 to get merged upstream, so I've already installed 18F/hookshot#json-options on the server: ``` npm install git+ssh://[email protected]/18F/hookshot.git#json-options ``` Note: I applied this in 18F/18f.gsa.gov#1102, but really should've just applied it here. No harm done, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18F/pages is a Hookshot server for https://pages.18f.gov/. As noted in 18F/pages#14, the default 100KB payload limit was exceeded by a webhook fired for uswds/uswds#54. This change will allow us to pass options through to the
bodyParser.json()middleware to increase the limit.I've currently installed this on our server using:
I've also updated our 18F/pages server to use this version, and verified that it addresses our problem, evidenced by the logs and the successful first deployment of https://pages.18f.gov/govt-wide-patternlibrary/.
cc: @juliaelman