Skip to content

fix(#86): Handle identity columns (sa.Identity) in version table - #191

Merged
ashish16052 merged 2 commits into
mainfrom
ashwin/contrib-2
Sep 1, 2026
Merged

fix(#86): Handle identity columns (sa.Identity) in version table#191
ashish16052 merged 2 commits into
mainfrom
ashwin/contrib-2

Conversation

@winwinashwin

Copy link
Copy Markdown
Contributor

Ensure identity generation metadata is not copied from a model column to
its version counterpart. History rows reuse the parent row's identifier
and must never generate a new one.

Fixes: #86

@winwinashwin winwinashwin changed the title fix(#86): Handle identity columns in version table fix(#86): Handle identity columns (sa.Identity) in version table Aug 29, 2026
@coveralls

coveralls commented Aug 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 33277016521

Coverage increased (+0.05%) to 96.018%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: 65 of 65 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5826
Covered Lines: 5594
Line Coverage: 96.02%
Coverage Strength: 9.54 hits per line

💛 - Coveralls

@winwinashwin

Copy link
Copy Markdown
Contributor Author

Closes #61

Ensure identity generation metadata is not copied from a model column to
its version counterpart. History rows reuse the parent row's identifier
and must never generate a new one.

Fixes: #86
@ashish16052
ashish16052 merged commit 5a19ca4 into main Sep 1, 2026
15 checks passed
@ashish16052
ashish16052 deleted the ashwin/contrib-2 branch September 1, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When I use sa.Identity() in my table - sqla-history version table doesnt work with alembic

3 participants