fix(#25): Handle polymorphic_on with CASE statement - #192
Draft
winwinashwin wants to merge 9 commits into
Draft
Conversation
winwinashwin
force-pushed
the
ashwin/contrib-3
branch
from
August 30, 2026 12:52
bad7103 to
a2b3665
Compare
The default value of sqlite for DB env var was not working during test collection. Instead use pytest configs and document things better.
winwinashwin
force-pushed
the
ashwin/contrib-3
branch
from
August 30, 2026 13:14
a2b3665 to
df937c2
Compare
Coverage Report for CI Build 33313654229Coverage increased (+0.02%) to 95.995%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
For every test, we were creating the engine and disposing it right away. This is not required and is rather expensive for databases like oracle and postgres. Instead use a single engine fixture with relevant scope. For oracle, this has reduced the time taken for tests by 4-5x
Make session fixtures opt-in, avoiding connection and DDL overhead for roughly 105 of 292 source test methods that don’t require a session. Keep model setup and versioning cleanup automatic, and detach pure mapper-argument tests from TestCase.
Create models and tables once per test class, then isolate individual tests with rollback-only transactions. Preserve mapper-only test optimization by skipping database setup for classes that do not require it. Reduces SQLite suite runtime from ~18.4s to ~7.4s, Oracle suite from 3m to ~50s.
winwinashwin
marked this pull request as draft
August 31, 2026 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.