Repository navigation
BUG: Use @ for Affine matrix multiplication - #942
Open
raashish1601 wants to merge 1 commit into
Open
raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
Author
|
The AppVeyor job hit its 60 minute limit while conda was still solving the environment (the log stops at "Collecting package metadata"), so no tests ran there. It isn't from this change; a rerun should get past it. |
Author
|
The ubuntu 3.12 job fails in the pylint step on W0613 (unused |
Member
That would be helpful. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rioxarray.open_rasteriostarting to emit warning from affine #937docs/history.rstfor all changes anddocs/rioxarray.rstfor new APIaffine 3 deprecates
*for matrix multiplication, soopen_rasterioandrio.transform(recalc=True)emit aPendingDeprecationWarning. This switches those calls to@. #939 did this before it was closed by its author; I followed the review there: only the matrix multiplication change, plus therasterio>=1.5.1andaffine>=3floors.Other changes needed for affine 3:
Affineis no longer a tuple, soassert_almost_equalon two transforms fails with "truth value of an array is ambiguous". This is what fails the 42 integration tests on master CI right now. Those asserts now comparetuple(transform).affine_to_coords(it also does on master with*). The centered transform is annotated asAnythere.New tests in
test/unit/test_spatial_utils.pyturnPendingDeprecationWarninginto an error and coveraffine_to_coords(rectilinear and rotated) andrio.transform(recalc=True). They fail on master and pass here.Tested in a Linux container with rasterio 1.5.2 and affine 3.0.1: the full suite goes from 59 to 17 failures. The 17 left fail the same way on master in that environment (no HDF4 driver in the rasterio wheel, and checksum differences in
test_clip_geojson__no_drop). pre-commit, mypy and pylint pass.