fix(aft-bridge): align PATH defaults to plugin

[tobwen]

Fixes #128

What is this about?

Three functions defaulted to ~/.cache/aft instead of the plugin's ~/.local/share/cortexkit/aft, causing standalone aft warmup to write to a different path than the plugin. The fallback now mirrors resolveCortexKitStorageRoot() from the plugin.

warmup.rs also never set ORT_DYLIB_PATH, so semantic index warmup failed with dlopen('libonnxruntime.so'). Now resolves the cached library from <storage_dir>/onnxruntime/1.24.4/ (and lib/ subdir) if ORT_DYLIB_PATH is not already set.

Hint

Currently, the version of onnxruntime was hardcoded, so I didn't change this.

---

^{Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.}

---

Summary by cubic

Aligns standalone AFT storage defaults with the plugin so both use the same cortexkit/aft path, and fixes aft warmup by auto-setting ORT_DYLIB_PATH from the cached ONNX Runtime to prevent dlopen errors.

• Bug Fixes
  • Unified storage fallbacks to match the plugin’s resolveCortexKitStorageRoot(): prefer XDG_DATA_HOME; on Windows use LOCALAPPDATA/APPDATA; else ~/.local/share/cortexkit/aft (Windows: AppData/Local/cortexkit/aft). Applied in bash_background::storage_dir, warmup_storage_dir, and search_index::resolve_cache_dir.
  • aft warmup --semantic now auto-sets ORT_DYLIB_PATH when unset by locating the cached library under <storage_dir>/onnxruntime/1.24.4/ (also checks lib/). Prevents dlopen('libonnxruntime.*')/missing DLL errors when running standalone.

^{Written for commit f984b57. Summary will update on new commits.}

Greptile Summary

This PR fixes path alignment between the standalone aft binary and the TypeScript plugin by updating three storage-root fallback functions to mirror resolveCortexKitStorageRoot() from packages/opencode-plugin/src/shared/storage-paths.ts (XDG → Windows LOCALAPPDATA → ~/.local/share/cortexkit/aft). It also adds try_set_ort_dylib_path to auto-set ORT_DYLIB_PATH before a semantic warmup when the env var is not already present.

• Path alignment (bash_background::storage_dir, warmup_storage_dir, search_index::resolve_cache_dir): all three fallback chains are updated to produce ~/.local/share/cortexkit/aft (Unix) / AppData\Local\cortexkit\aft (Windows) instead of ~/.cache/aft, matching what the plugin writes.
• ORT dlopen fix (warmup.rs): try_set_ort_dylib_path probes <storage_dir>/onnxruntime/1.24.4/<lib> and <storage_dir>/onnxruntime/1.24.4/lib/<lib>, mirroring the two-location resolution in onnx-runtime.ts::resolveCachedOnnxRuntimeDir, and sets ORT_DYLIB_PATH if a match is found. A unit test covering the root-level probe path is included.

Confidence Score: 5/5

• Safe to merge — the changes are mechanical path alignment with the TS plugin and a targeted ORT library probe; no production logic is altered beyond the storage root default.
• All three storage-root updates are straightforward substitutions of ~/.cache/aft with the XDG-compliant chain already used by the plugin, and the new try_set_ort_dylib_path only acts when ORT_DYLIB_PATH is unset. The only findings are a missing test variant for the lib/ subdir probe path and the three-way duplication of the XDG resolution block — neither is a functional defect in the changed paths.
• crates/aft/src/cli/warmup.rs — the try_set_ort_dylib_path probe and its test are the most novel code; the lib/ subdir case has no test coverage.

Important Files Changed

Filename	Overview
crates/aft/src/cli/warmup.rs	Adds try_set_ort_dylib_path to auto-resolve ORT_DYLIB_PATH before semantic warmup, and updates warmup_storage_dir to use the XDG-compliant fallback chain. The version string "1.24.4" is hardcoded in the probe path (already flagged in previous review); the test covers the root-level probe but not the lib/ subdir case.
crates/aft/src/bash_background/mod.rs	Updates storage_dir fallback to use XDG_DATA_HOME / LOCALAPPDATA / ~/.local/share/cortexkit/aft, correctly mirroring the TS plugin's resolution order.
crates/aft/src/search_index.rs	Updates resolve_cache_dir fallback to the same XDG-compliant chain; logic is consistent with the other two updated functions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[aft warmup --semantic] --> B[warmup_storage_dir]
    B --> C{AFT_STORAGE_DIR set?}
    C -->|yes| D[return AFT_STORAGE_DIR]
    C -->|no| E{XDG_DATA_HOME set?}
    E -->|yes| F[return XDG_DATA_HOME/cortexkit/aft]
    E -->|no| G{Windows?}
    G -->|yes| H{LOCALAPPDATA or APPDATA?}
    H -->|yes| I[return LocalAppData/cortexkit/aft]
    H -->|no| J[home = USERPROFILE or HOME or temp]
    G -->|no| K[home = HOME or temp]
    J --> L[return home/AppData/Local/cortexkit/aft]
    K --> M[return home/.local/share/cortexkit/aft]

    D --> N[try_set_ort_dylib_path]
    F --> N
    I --> N
    L --> N
    M --> N

    N --> O{ORT_DYLIB_PATH already set?}
    O -->|yes| P[skip - env wins]
    O -->|no| Q[probe storage_dir/onnxruntime/1.24.4/libonnxruntime.so]
    Q --> R{file exists?}
    R -->|yes| S[set ORT_DYLIB_PATH = file path]
    R -->|no| T[probe .../lib/libonnxruntime.so]
    T --> U{file exists?}
    U -->|yes| S
    U -->|no| V[silent no-op - ORT_DYLIB_PATH stays unset]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[aft warmup --semantic] --> B[warmup_storage_dir]
    B --> C{AFT_STORAGE_DIR set?}
    C -->|yes| D[return AFT_STORAGE_DIR]
    C -->|no| E{XDG_DATA_HOME set?}
    E -->|yes| F[return XDG_DATA_HOME/cortexkit/aft]
    E -->|no| G{Windows?}
    G -->|yes| H{LOCALAPPDATA or APPDATA?}
    H -->|yes| I[return LocalAppData/cortexkit/aft]
    H -->|no| J[home = USERPROFILE or HOME or temp]
    G -->|no| K[home = HOME or temp]
    J --> L[return home/AppData/Local/cortexkit/aft]
    K --> M[return home/.local/share/cortexkit/aft]

    D --> N[try_set_ort_dylib_path]
    F --> N
    I --> N
    L --> N
    M --> N

    N --> O{ORT_DYLIB_PATH already set?}
    O -->|yes| P[skip - env wins]
    O -->|no| Q[probe storage_dir/onnxruntime/1.24.4/libonnxruntime.so]
    Q --> R{file exists?}
    R -->|yes| S[set ORT_DYLIB_PATH = file path]
    R -->|no| T[probe .../lib/libonnxruntime.so]
    T --> U{file exists?}
    U -->|yes| S
    U -->|no| V[silent no-op - ORT_DYLIB_PATH stays unset]

Loading

_{Reviews (2): Last reviewed commit: "fix: align standalone storage dir fallba..." | Re-trigger Greptile}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

2 issues found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="crates/aft/src/cli/warmup.rs">

<violation number="1" location="crates/aft/src/cli/warmup.rs:294">
P1: Hardcoded ONNX Runtime version string can drift from the actual cached ORT version and break semantic warmup.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: Hardcoded ONNX Runtime version string can drift from the actual cached ORT version and break semantic warmup.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/aft/src/cli/warmup.rs, line 294:

<comment>Hardcoded ONNX Runtime version string can drift from the actual cached ORT version and break semantic warmup.</comment>

<file context>
@@ -248,11 +254,50 @@ fn warmup_storage_dir() -> PathBuf {
+    } else {
+        "libonnxruntime.so"
+    };
+    let ort_dir = storage_dir.join("onnxruntime").join("1.24.4");
+    for candidate in [ort_dir.join(lib_name), ort_dir.join("lib").join(lib_name)] {
+        if candidate.is_file() {
</file context>

[tobwen]

Pre-existing pattern! The plugin side already pins 1.24.4 in two separate files (onnx-runtime.ts, onnx.ts). The Rust string is a third copy. Cross-language constant sync would require build-time codegen, which is out of scope for this fix.

[greptile-apps]

Silent no-op when library not cached

try_set_ort_dylib_path returns without setting ORT_DYLIB_PATH (and without any diagnostic) if neither candidate path exists. The subsequent configure call will then hit the same dlopen failure this fix is meant to prevent, with no indication of why. A user who hasn't yet run the plugin (so the library was never downloaded) will see the exact same opaque error as before. At minimum, an eprintln! warning pointing to the expected path would help with diagnosis.

[greptile-apps]

The version string "1.24.4" is hardcoded in the library probe path. When the plugin upgrades its ONNX Runtime cache (e.g. onnxruntime/1.25.0/), try_set_ort_dylib_path will silently find nothing and ORT_DYLIB_PATH will remain unset. Given the PR description already acknowledges this, consider at least making it a named constant so there is a single place to update.

Suggested change

	let ort_dir = storage_dir.join("onnxruntime").join("1.24.4");
	const ORT_VERSION: &str = "1.24.4";
	let ort_dir = storage_dir.join("onnxruntime").join(ORT_VERSION);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!