Creating feature flag for disabling replica set extension #7153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-wu26
force-pushed
the
fix-shuffle-shard
branch
from
b488770 to
eac5a84
Compare
b-wu26
changed the title
pkg/alertmanager/distributor.go
Outdated
| randN := rand.Intn(len(replicationSet.Instances)) | ||
| instances = replicationSet.Instances[randN : randN+1] | ||
| // For POST requests, add retry logic to PutSilence | ||
| if d.isUnaryWritePath(r.URL.Path) { |
Contributor
There was a problem hiding this comment.
Can this be just a || in the if condition? for example if req.GetMethod() == "GET" || req.GetMethod() == "DELETE" || d.isUnaryWritePath(r.URL.Path)?
| receivers = append(receivers, parsed...) | ||
| } | ||
|
|
||
| merged := mergeV2Receivers(receivers) |
Contributor
There was a problem hiding this comment.
Could this be done as part of the for loop? I mean can we maintain a map and dedup as we go
b-wu26
force-pushed
the
fix-shuffle-shard
branch
2 times, most recently
from
e8e8590 to
2e1bdf7
Compare
yeya24
reviewed
Jan 8, 2026
| ) | ||
|
|
||
| // RingOp is the operation used for reading/writing to the alertmanagers. | ||
| // Original ring operations (with extension enabled for backward compatibility) |
Contributor
There was a problem hiding this comment.
I wouldn't call it Original. We are not deprecating this one and DisableReplicaSetExtension is false by default.
| // Original ring operations (with extension enabled for backward compatibility) | ||
| var RingOp = ring.NewOp([]ring.InstanceState{ring.ACTIVE}, func(s ring.InstanceState) bool { | ||
| // Only ACTIVE Alertmanager get requests. If instance is not ACTIVE, we need to find another Alertmanager. | ||
| // Original behavior: extend replica set if instance is not ACTIVE |
Contributor
There was a problem hiding this comment.
Remove all original behavior from this PR
yeya24
reviewed
Jan 8, 2026
b-wu26
force-pushed
the
fix-shuffle-shard
branch
2 times, most recently
from
38b63a6 to
74784e6
Compare
b-wu26
changed the title
b-wu26
force-pushed
the
fix-shuffle-shard
branch
2 times, most recently
from
146915c to
3b363bf
Compare
yeya24
reviewed
Jan 8, 2026
…e and api improvements Signed-off-by: Brenden Wu <[email protected]>
b-wu26
force-pushed
the
fix-shuffle-shard
branch
from
3b363bf to
78ced0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using cortex, my team recently ran into an issue with the alert managers where a corrupt config was synced and extended across the entire alert manager ring. This led to our entire fleet being stuck in a crash loop back off and prompted a need to limit the blast radius of potential issues to the replication factor
What this PR does:
Which issue(s) this PR fixes:
#7200
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]