ruler: Refactor query execution and tenant factory logic #7172
+90
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
component/rules
SungJin1212
force-pushed
the
refactor/ruler-query-func-cleanup
branch
from
dcdf8b5 to
31095c9
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
refactor/ruler-query-func-cleanup
branch
from
31095c9 to
e996f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
pkg/ruler/compat.goto improve code readability and maintainability.Previously,
EngineQueryFuncandDefaultTenantManagerFactorycontained mixed responsibilities.This is a pure refactoring change. There are no changes to the logic or behavior of the ruler.
EngineQueryFuncRefactoring:wrapWithMiddleware.DefaultTenantManagerFactoryRefactoring:buildQueryFuncto encapsulate the composition of the query functionWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]