Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Redis round-trips during cache migration by caching the Redis server version check and reordering existence checks to short-circuit earlier when the migrated hash already exists.
Changes:
- Cache the Redis server version check to avoid repeated
INFOcalls. - Check for the new (migrated) hash first to skip legacy lookups when migration is already complete.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- cache server version - check the new hash name first
ville
force-pushed
the
fix/remove-extra-redis-calls
branch
from
d4fd16e to
7307267
Compare
smoke
approved these changes
Mar 24, 2026
corva-alex-s
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Removes extra Redis calls to reduce latency
Changes
TODO