fix: PRINT/PRINTF return false when weakened data ref is gone#283
Draft
Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Draft
fix: PRINT/PRINTF return false when weakened data ref is gone#283Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Conversation
PRINT and PRINTF always returned 1 (success) even when _write_bytes() failed because the mock was destroyed and the weakened data ref became undef. WRITE already handled this correctly by checking the return value. Apply the same pattern to PRINT and PRINTF for consistency. Also skips _update_write_times() when no bytes were written, matching WRITE's existing behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PRINT and PRINTF now check
_write_bytes()return value instead of unconditionally returning 1.Why
When a mock is destroyed while a filehandle is still open, the weakened data ref becomes undef.
_write_bytes()correctly returns 0 with$! = EBADFin this case, but PRINT/PRINTF ignored the failure and returned 1 (success). WRITE already handled this correctly — this aligns PRINT/PRINTF with the same pattern.How
_write_bytes()return; only call_update_write_times()when bytes were written$bytes ? 1 : 0to match PRINT/PRINTF's boolean contract (vs WRITE's byte-count contract)printandprintfafter mock destruction, verifying false return and EBADF errnoTesting
t/filehandle_weakref.t: existing print subtest now asserts return value and errno; new printf subtest added🤖 Generated with Claude Code