Fix #14689 (html report: Fix missing severity and classification bars)

[vkucera]

Fixes a bug introduced in #7994.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[danmar]

lgtm

[vkucera]

lgtm

Thanks for the review. Is there anything left before it can be merged?

[danmar]

does this suggestion below make sense? I asked claude about how to test this..

filter_bar() is called during full report generation. Since example.xml already contains severity="error" and severity="style", an integration test can assert that the severity bar
checkboxes actually appear in index.html. Before the fix, the entire severity bar was silently cleared to '', so toggleSeverity never appeared in the output.

Add one test method to test_htmlreport.py:

  def testSeverityFilterBar(self):                                                                                                                                                           
      """Regression test for #14689: severity bar must appear when errors exist."""
      with runCheck(xml_filename=os.path.join(TEST_TOOLS_DIR, 'example.xml')) as (report, output_directory):                                                                                 
          # example.xml contains error and style severities, so the                                                                                                                          
          # severity filter bar must be present. Before the fix in #7994,                                                                                                                    
          # filter_bar() checked for "checked/>" (XHTML) but filter_button()                                                                                                                 
          # emits "checked>" (HTML5), so the bar was always cleared to ''.                                                                                                                   
          self.assertIn('toggleSeverity', report)                                                                                                                                            
          output_directory.cleanup()                                                                                                                                                         

[vkucera]

Hi @danmar , thanks for the suggestion.
The test written by Claude would not work because toggleSeverity is a name of a javascript function which always appears in the report.
I added a modified version which does work.
Let me know if it looks good to you.