Skip to content

Fix #14716 FP oppositeInnerCondition, x.size() < y.size() does not mean that x must be empty #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
May 6, 2026
+7 −1
Merged

Fix #14716 FP oppositeInnerCondition, x.size() < y.size() does not mean that x must be empty #8533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcee438
Update astutils.cpp
chrchr-github May 6, 2026
d6b44d9
Update testcondition.cpp
chrchr-github May 6, 2026
9283d02
Merge branch 'cppcheck-opensource:main' into chr_14716
chrchr-github May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ static bool isZeroBoundCond(const Token * const cond, bool reverse)

const Token* op = reverse ? cond->astOperand1() : cond->astOperand2();
if (!op->hasKnownIntValue())
return false;
return true;

// Assume unsigned
const bool isZero = op->getKnownIntValue() == 0;
Expand Down
6 changes: 6 additions & 0 deletions test/testcondition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2682,6 +2682,12 @@ class TestCondition : public TestFixture {
check("void f1(const std::string &s) { if(s.empty()) if(42 < s.size()) {}}");
ASSERT_EQUALS("[test.cpp:1:43] -> [test.cpp:1:53]: (warning) Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]\n", errout_str());

check("void f(const std::string& s, int n) {\n" // #14716
" if (s.size() < n)\n"
" if (s.empty()) {}\n"
"}");
ASSERT_EQUALS("", errout_str());

// TODO: These are identical condition since size cannot be negative
check("void f1(const std::string &s) { if(s.size() <= 0) if(s.empty()) {}}");
ASSERT_EQUALS("", errout_str());
Expand Down
Loading