WIP: deserializeValue: try to fix IPLPoint/IPLColor loading#110
Open
drzraf wants to merge 1 commit intocpvrlab:masterfrom
Open
WIP: deserializeValue: try to fix IPLPoint/IPLColor loading#110drzraf wants to merge 1 commit intocpvrlab:masterfrom
drzraf wants to merge 1 commit intocpvrlab:masterfrom
Conversation
Author
|
ping |
drzraf
changed the title
…to 0) using some C++11
drzraf
force-pushed
the
json-deserialize
branch
from
a6de2bc to
a0d97db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[don't merge]
These kind of serialized values are always reset to 0 when loaded.
I tried to fix that without success: ironically
std::stof(match.str(X)always returned 0 too.Hopefully you may get the idea and fix the issue.
Note: even if not directly related, I also found that some color may be represented with an exponent, the reason why I modified the regexp.