Implement CRMI $create-changelog operation (R4)#910
Merged
Conversation
|
Formatting check succeeded! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
============================================
- Coverage 73.79% 71.71% -2.08%
Complexity 364 364
============================================
Files 601 605 +4
Lines 29548 30417 +869
Branches 3922 4099 +177
============================================
+ Hits 21804 21815 +11
- Misses 5830 6687 +857
- Partials 1914 1915 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Chris0296
force-pushed
the
cor-changelog-operation
branch
3 times, most recently
from
b4c1144 to
2b5d609
Compare
Clean up pending
Chris0296
force-pushed
the
cor-changelog-operation
branch
from
72229a3 to
fff5a28
Compare
Chris0296
force-pushed
the
cor-changelog-operation
branch
from
6f77b99 to
482b567
Compare
Previous data had the same VS version in both source and target, though the target was missing the name. Repository search was returning them in seemingly random order, leading to intermittent failure of this test. Updated name and version of the target VS to make them distinct.
c-schuler
requested changes
Mar 31, 2026
Contributor
c-schuler
left a comment
c-schuler
left a comment
There was a problem hiding this comment.
Phew, that is a lot of work! Most of it looks really good - could be cleaned up a bit in a few spots however. See my requested changes
Include static block to ensure graceful shutdown of shared thread pool
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added $create-changelog operation processors
Added the operation to the R4 CR config
Added operation documentation
Added tests
Issue tracking operation migration process: DBCG/aphl-vsm#604