Skip to content

Deduplicate logicDefinition extensions on the moduleDefinitionLibrary#594

Merged
c-schuler merged 2 commits intomasterfrom
refresh-dedup-logicDefinition
Apr 16, 2026
Merged

Deduplicate logicDefinition extensions on the moduleDefinitionLibrary#594
c-schuler merged 2 commits intomasterfrom
refresh-dedup-logicDefinition

Conversation

@c-schuler
Copy link
Copy Markdown
Contributor

Adding de-duplication logic for logicDefinition extensions during refresh. These were reported by a user and confirmed through local testing. The "proper" fix is in the data requirements processing in the translator, but this code also works here as a defensive measure. I will also be addressing this issue in the translator

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@c-schuler c-schuler self-assigned this Apr 7, 2026
@c-schuler c-schuler added the bug Something isn't working label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.92%. Comparing base (1524d69) to head (156af79).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../org/opencds/cqf/tooling/operation/ig/Refresh.java 0.00% 5 Missing ⚠️
...ds/cqf/tooling/utilities/LogicDefinitionUtils.java 73.68% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #594      +/-   ##
============================================
+ Coverage     19.88%   19.92%   +0.03%     
- Complexity     1675     1687      +12     
============================================
  Files           311      312       +1     
  Lines         27663    27689      +26     
  Branches       4367     4376       +9     
============================================
+ Hits           5501     5517      +16     
- Misses        21237    21242       +5     
- Partials        925      930       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change mentioned for consideration. Other than that, looks good.

Comment thread tooling/src/main/java/org/opencds/cqf/tooling/operation/ig/Refresh.java Outdated
@c-schuler c-schuler merged commit 11b055c into master Apr 16, 2026
4 checks passed
@c-schuler c-schuler deleted the refresh-dedup-logicDefinition branch April 16, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants