Deduplicate logicDefinition extensions on the moduleDefinitionLibrary#594
Merged
Deduplicate logicDefinition extensions on the moduleDefinitionLibrary#594
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
============================================
+ Coverage 19.88% 19.92% +0.03%
- Complexity 1675 1687 +12
============================================
Files 311 312 +1
Lines 27663 27689 +26
Branches 4367 4376 +9
============================================
+ Hits 5501 5517 +16
- Misses 21237 21242 +5
- Partials 925 930 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brynrhodes
approved these changes
Apr 7, 2026
sliver007
approved these changes
Apr 16, 2026
Collaborator
sliver007
left a comment
There was a problem hiding this comment.
One change mentioned for consideration. Other than that, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding de-duplication logic for logicDefinition extensions during refresh. These were reported by a user and confirmed through local testing. The "proper" fix is in the data requirements processing in the translator, but this code also works here as a defensive measure. I will also be addressing this issue in the translator
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0