Mock the connection #509
Open
kneth wants to merge 1 commit into
Open
Conversation
mfussenegger
left a comment
mfussenegger
left a comment
Member
There was a problem hiding this comment.
I suspect this is to fix #508 ?
Would be nice of the commit message mentioned that. E.g "Fix commands tests" with a body that mentions that the tests tried to connect to a server. That it replaces one mock with another to fix that is imho secondary.
kneth
force-pushed
the
kneth/mock-connection
branch
from
July 14, 2026 15:15
0d6b54c to
58397fb
Compare
The tests tried to connect to a non-existing server, and tests will subsequently fail.
kneth
force-pushed
the
kneth/mock-connection
branch
from
July 14, 2026 15:17
58397fb to
0f2428e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Mock the connection instead of the cursor to avoid trying to connect to non-existing server
Checklist