Fix MaxAllCPU signature drift in cratedb/questdb generators#4
Merged
Conversation
florinutz
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tsbs_generate_queriespanics withunimplemented queryfor everycpu-max-all-*query type with the cratedb and questdb formats.Upstream PR timescale#168 changed the
MaxAllCPUfiller signature to take aduration time.Durationparameter and updated most generators, but missed four (cratedb, questdb, akumuli, timestream). Dispatch happens through a type assertion incmd/tsbs_generate_queries/uses/devops/max_all_cpu.go, so the stale 2-arg methods fail theMaxAllFillerassertion at runtime instead of breaking the build.Also submitted upstream as timescale#293, but upstream appears unmaintained, merging here so the fork's master is usable
Verification
go test -vet=off ./cmd/tsbs_generate_queries/databases/cratedb/ ./cmd/tsbs_generate_queries/databases/questdb/passes; suite smoke runs includecpu-max-all-1end-to-end.