Update README for interact() and version 4.1.#59
Merged
Conversation
Move the deprecated get()/store() instructions to docs/get-store.md and link to them from the README. Link "interaction URL" to the VCALM specification. Bump the recommended install version from 3.x to 4.1. Clarify that wallet providers do not call navigator.credentials; registration uses CredentialManager.requestPermission() and handlers receive requests via events or a protocols query parameter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
djscruggs
marked this pull request as ready for review
July 2, 2026 19:21
dlongley
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
<script>tag andpackage.jsonsnippet).get()/store()walkthrough (get(),store(),WebCredential, Handling Empty Results) out of the README intodocs/get-store.md; the README keeps a short deprecation callout that links to it for existing integrations.interact()section and the deprecation callout.interact()now, and wallet providers do not callnavigator.credentialsat all — registration usesCredentialManager.requestPermission()(which goes throughnavigator.credentialsPolyfill.permissions), and handlers receive requests via events or aprotocolsquery parameter. This means a future removal of thenavigator.credentialspatching is a no-op for wallets.Notes
interact()under-the-hood paragraph still referencenavigator.credentials.get()/store()— accurate for the current implementation; they should be revisited when thenavigator.credentialspatching is actually removed.npm run lintandnpm testpass locally (20 passed, 1 skipped WebKit case).🤖 Generated with Claude Code