Conversation
Observe rejected any external-name that was not a numeric ID, so an observe-only Group could not be declared when only the path was known. GitLab's GET /groups/:id accepts the URL-encoded full path as well, and Update and Delete already pass the external-name through unchanged. Pass the external-name to the lookup as it is. The annotation is not rewritten to the ID: a Composition re-applies the annotation on every reconcile, so any value the provider wrote would be reverted. Refs crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
Apply the same lookup as for groups: a non-numeric external-name is sent to GET /projects/:id as the full path. GitLab follows its redirect routes for projects, so the lookup keeps working after a rename. Refs crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
Observe-only Group and Project examples show the path form. Fixes crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
ahauserv
force-pushed
the
feat/path-external-name
branch
from
September 22, 2026 09:50
b2ce50c to
c44f431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I want to declare observe-only
GroupandProjectresources for cases where only the full path is known, not the numeric ID.crossplane.io/external-nameis still the ID.Observeis removed.LateInitialize, loop.Note
GitLab follows its redirect routes for renamed projects, so a project lookup by the old path keeps working. It does not for groups; an observe-only group renamed in GitLab needs its annotation updated. A fully managed group is renamed back by drift correction anyway.
Fixes #318
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested