feat(postgres): Add support for setting STRATEGY during db creation#343
Open
alexdor wants to merge 2 commits into
Open
feat(postgres): Add support for setting STRATEGY during db creation#343alexdor wants to merge 2 commits into
alexdor wants to merge 2 commits into
Conversation
alexdor
force-pushed
the
ado/feat-strategy-for-pg
branch
from
bb8246b to
279a689
Compare
alexdor
force-pushed
the
ado/feat-strategy-for-pg
branch
from
3601ded to
076d337
Compare
Author
|
@fernandezcuesta sorry I thought that it was a flaky test (because it would pass locally sometimes, and I didn't touch any of the mysql parts). Should be fixed now |
alexdor
force-pushed
the
ado/feat-strategy-for-pg
branch
from
076d337 to
23b5af6
Compare
Add PostgreSQL Database strategy support for template-based database creation and make its lifecycle explicit in the API. The new strategy field is treated as create-time-only, and validated so updates do not silently drift from the real database state. Fail fast when strategy is requested against PostgreSQL versions older than 15 instead of letting CREATE DATABASE fail with a less clear SQL error. closes crossplane-contrib#341 Signed-off-by: Alexandros Dorodoulis <aldor94@gmail.com>
Signed-off-by: Alexandros Dorodoulis <aldor94@gmail.com>
alexdor
force-pushed
the
ado/feat-strategy-for-pg
branch
from
23b5af6 to
e298bba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add PostgreSQL Database strategy support for template-based database creation and make its lifecycle explicit in the API. The new strategy field is treated as create-time-only, and validated so updates do not silently drift from the real database state.
Fail fast when strategy is requested against PostgreSQL versions older than 15 instead of letting CREATE DATABASE fail with a less clear SQL error.
Fixes #341
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested