Bump tls to 2.2.2 in flake and stack - #1581
Merged
Merged
Conversation
tls < 2.2.2 is affected by haskell-tls/hs-tls#515. tls 2.2.2 needs the crypton-x509 1.8 line, which still builds against crypton 1.0.x (the 1.9 line would force crypton >= 1.1 and a much wider cascade). No crypton-connection release targets tls 2.2 (0.4.5 caps < 2.2, 0.4.6 needs >= 2.3), so its tls < 2.2 bound is relaxed, along with warp-tls and tls-session-manager (pulled in by Hoogle in the dev shell); all compile fine against 2.2.2. In flake.nix the codegen cabal2nix is pinned to the un-overridden base set, otherwise regenerating tls via callHackageDirect loops (cabal2nix transitively depends on tls). stack.yaml additionally pins the crypton-asn1-*/crypton-pem/time-hourglass/hpke/ech-config packages that lts-23.24 lacks; nixpkgs-unstable already carries compatible versions.
crypton-connection 0.4.5 needs crypton-socks >= 0.6, which lts-23.24 does not provide. Matches the version the flake already resolves.
Collaborator
|
This works correctly in stack, let merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tls < 2.2.2 is affected by haskell-tls/hs-tls#514.
tls 2.2.2 needs the crypton-x509 1.8 line, which still builds against crypton 1.0.x (the 1.9 line would force crypton >= 1.1 and a much wider cascade). No crypton-connection release targets tls 2.2 (0.4.5 caps < 2.2, 0.4.6 needs >= 2.3), so its tls < 2.2 bound is relaxed, along with warp-tls and tls-session-manager (pulled in by Hoogle in the dev shell); all compile fine against 2.2.2.
In flake.nix the codegen cabal2nix is pinned to the un-overridden base set, otherwise regenerating tls via callHackageDirect loops (cabal2nix transitively depends on tls). stack.yaml additionally pins the crypton-asn1-*/crypton-pem/time-hourglass/hpke/ech-config packages that lts-23.24 lacks; nixpkgs-unstable already carries compatible versions.