OCM: Handle ROCrate #5452
Open
OCM: Handle ROCrate #5452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rawe0
force-pushed
the
handle-ro-crate
branch
from
2427a65 to
21e9b0d
Compare
rawe0
force-pushed
the
handle-ro-crate
branch
from
9378def to
21e9b0d
Compare
rawe0
force-pushed
the
handle-ro-crate
branch
7 times, most recently
from
88174ee to
0d1d842
Compare
rawe0
force-pushed
the
handle-ro-crate
branch
from
0d1d842 to
05801e7
Compare
glpatcern
requested changes
Jan 5, 2026
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
It looks generally good though there are some changes. I'm going to stack another PR on top of this one so please once you're back just add commits without overwriting the history ;-)
| w.WriteHeader(http.StatusOK) | ||
| } | ||
|
|
||
| func CS3ResourcePermissionsToUnifiedRole(ctx context.Context, p *storageprovider.ResourcePermissions) *libregraph.UnifiedRoleDefinition { |
Member
There was a problem hiding this comment.
This and the following funcs / structs should already exist in the generic conversions utilities (and if not, they should go there) as they are not specific to the embedded OCM protocol.
glpatcern
force-pushed
the
handle-ro-crate
branch
from
a730d59 to
341b1f2
Compare
glpatcern
force-pushed
the
handle-ro-crate
branch
from
341b1f2 to
d736cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
ListReceivedOCMSharescall and adapts to the new fieldsSharedResourceTypeandRecipientType