Skip to content

Fix TM1Service kwarg collision when connection params set in config.ini #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MariusWirtz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TM1Service kwarg collision when connection params set in config.ini #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/rushti/execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,15 @@ def setup_tm1_services(
# case no connection file provided or connection file expired
if tm1_server_name not in tm1_services:
resolved_params = resolve_tm1_params(config, tm1_server_name)
tm1_services[tm1_server_name] = TM1Service(
**resolved_params,
session_context=session_context,
connection_pool_size=max_workers,
)
# RushTI-managed defaults; any value explicitly set in
# config.ini takes precedence (avoids "multiple values for
# keyword argument" when e.g. connection_pool_size is set).
service_kwargs = {
"session_context": session_context,
"connection_pool_size": max_workers,
}
service_kwargs.update(resolved_params)
tm1_services[tm1_server_name] = TM1Service(**service_kwargs)

if connection_file:
# implicitly re-connects if session is timed out
Expand Down
Loading