Update .gitignore and fixed third-party libs import#334
Open
timongentzsch wants to merge 1 commit intocvg:masterfrom
Open
Update .gitignore and fixed third-party libs import#334timongentzsch wants to merge 1 commit intocvg:masterfrom
timongentzsch wants to merge 1 commit intocvg:masterfrom
Conversation
(when installed in non editable mode)
Member
|
Thanks for the PR. This seems a little complicated, can't we simply move |
Author
|
sure, i just thought it would be nice to keep hloc source and third_party separated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installed in non editable mode (without
-e) third_party folder wasn't included. This commit fixes the imports for installing in editable and non-editable mode.