Fix BackedEnum support when bStrictObjectTypeChecking is enabled#253
Open
djairhogeuens wants to merge 1 commit intocweiske:masterfrom
Open
Fix BackedEnum support when bStrictObjectTypeChecking is enabled#253djairhogeuens wants to merge 1 commit intocweiske:masterfrom
djairhogeuens wants to merge 1 commit intocweiske:masterfrom
Conversation
Closes cweiske#247. BackedEnum cases are represented in JSON as their scalar backing value (string or int). Strict object type checking previously rejected scalar to object conversion across the board, which made BackedEnum properties unusable when the (default) bStrictObjectTypeChecking flag was on. Add a narrow exemption: when the target class is a \BackedEnum subclass, fall through to the existing createInstance($class, true, $jvalue) path, which already handles \::from($jvalue) correctly. Strict checking for non-enum classes is unchanged, and invalid enum values still raise \ValueError. Adds tests/EnumsStrictTypes_PHP81_Test (9 tests) and a fixture for array-of-enum and nullable-enum cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #247.
BackedEnum cases are represented in JSON as their scalar backing value (string or int). Strict object type checking previously rejected scalar to object conversion across the board, which made BackedEnum properties unusable when the (default) bStrictObjectTypeChecking flag was on.
Add a narrow exemption: when the target class is a \BackedEnum subclass, fall through to the existing createInstance($class, true, $jvalue) path, which already handles ::from($jvalue) correctly. Strict checking for non-enum classes is unchanged, and invalid enum values still raise \ValueError.
Adds tests/EnumsStrictTypes_PHP81_Test (9 tests) and a fixture for array-of-enum and nullable-enum cases.