Repository navigation
test: run the tests on Testo with cycle/testing - #139
Merged
Merged
Conversation
PHPUnit stays the test runner until the tests are migrated. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
A mechanical pass of the PHPUNIT_TO_TESTO set, kept apart from the harness migration so the hand-written changes review on their own; the generated per-driver stubs are left for that step to delete. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
The harness runs a common test in every driver suite, so the generated per-driver stubs and their generator go, and the copied table and logger helpers give way to the package. CompositePkGeneratedTest now also runs on SQL Server, the other RETURNING driver its docblock names. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
ci: run each server driver in its own job docs: describe running the tests in the README Server drivers run on the lowest and highest supported PHP only, to keep the job count down; the full PHP matrix still runs Unit and SQLite. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #139 +/- ##
============================================
- Coverage 91.93% 87.28% -4.65%
============================================
Files 39 39
Lines 843 873 +30
============================================
- Hits 775 762 -13
- Misses 68 111 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The PHP matrix job ran the Unit suite without coverage, so Codecov lost the lines only unit tests reach. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The test suite runs on Testo through the shared
cycle/testingharness instead of PHPUnit.tests/Annotated/Functional/Driver/{Common,<Driver>}→tests/Feature/{Common,MySQL,Postgres}. A common test runs in every driver suite, so the 87 generated per-driver stubs go;BaseTestCaseextends the harness'sOrmTestCaseand keeps only the reader providers and the fixture locator.TableTrait,TableRendererand theTestLoggerfixture give way to the harness; PHPUnit mocks ofClassesInterfacebecomeClassList.test,test:unit,test:<driver>,db:up/db:down(the package's compose file). README gets a Testing section.main.ymlcalls the sharedcycle/gh-actionsworkflowtesto.yml: Unit + SQLite on PHP 8.2–8.6 with highest dependencies and on 8.2 with lowest, MySQL, Postgres and SQL Server on 8.2 and 8.6, Codecov flag per suite.testo.phpregisters a Regression suite, andcomposer test:new-case -- <issue>generates a case intests/Regressionfrom the harness'sorm-attributestemplate.phpunit.xml,tests/bootstrap.php,tests/generate.php,tests/docker-compose.ymland the Travis-era shell scripts; PHPUnit leavesrequire-dev.Test counts
Deliberate differences:
CompositePkGeneratedTest(×6) also runs on SQL Server, the otherRETURNINGdriver its docblock names; PHPUnit ran it on Postgres only.Review notes
infection.jsonhas no workflow and Infection is not installed; it is left as is and still assumes PHPUnit.Checklist